Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junos config generation improvements #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+27 −14
Open

Junos config generation improvements #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3ec2b0
Fixed redundant local-as config for Junos
Jun 21, 2019
b776edc
Fixed redundant local-as config for Junos
Jun 21, 2019
d0c0bc8
Updated redundant local-as logic
Jun 21, 2019
6ffe8c8
Fixed redundant local-as for Junos set
Jun 21, 2019
65859ad
Fixed redundant peer-type for Junos set
Jun 21, 2019
2f6e95d
Changed getting BGP group name for Junos set
Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/netom/templates/netom0/junos-0/bgp/neighbors.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
{% set printed_localas = { 'flag': false } %}
{% for name, group in peer_groups.items() %}
group {{ name }} {
type {{ peer_type }};
{% for peer in group %}
{% if peer.local_address %}
local-address {{ peer.local_address }};
{% endif %}
{% if peer.local_as %}
{% if printed_localas.flag == false %}
local-as {{ peer.local_as }};
{% if printed_localas.update({ 'flag': true }) %}{% endif %}
{% endif %}
{% endif %}
{% if peer.enabled == False %}
inactive: neighbor {{ peer.neighbor_address }} {
Expand Down Expand Up @@ -37,4 +42,4 @@ group {{ name }} {
}
{% endfor %}
}
{% endfor %}
{% endfor %}
34 changes: 21 additions & 13 deletions src/netom/templates/netom0/junos-set-0/bgp/neighbors.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,38 @@
{% set printed_localas = { 'flag': false } %}
{% set printed_type = { 'flag': false } %}
{% for name, group in peer_groups.items() %}
{% for peer in group %}
set protocols bgp group {{ peer.peer_group }} type {{ peer.peer_type }}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} peer-as {{ peer.peer_as }}
{% if printed_type.flag == false %}
set protocols bgp group {{ name }} type {{ peer.peer_type }}
{% if printed_type.update({ 'flag': true }) %}{% endif %}
{% endif %}
{% if peer.local_as %}
{% if printed_localas.flag == false %}
set protocols bgp group {{ name }} local-as {{ peer.local_as }}
{% if printed_localas.update({ 'flag': true }) %}{% endif %}
{% endif %}
{% endif %}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} peer-as {{ peer.peer_as }}
{% if peer.description %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} description "{{ peer.description }}"
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} description "{{ peer.description }}"
{% endif %}
{% if peer.local_address %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} local-address {{ peer.local_address }}
{% endif %}
{% if peer.local_as %}}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} local-as {{ peer.local_as }}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} local-address {{ peer.local_address }}
{% endif %}
{% if peer.import_policy %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} import {{ peer.import_policy }}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} import {{ peer.import_policy }}
{% endif %}
{% if peer.export_policy %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} export {{ peer.export_policy }}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} export {{ peer.export_policy }}
{% endif %}
{% if peer.auth_password %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} authentication-key {{ peer.auth_password }}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} authentication-key {{ peer.auth_password }}
{% endif %}
{% if peer.max_prefixes %}
set protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }} family inet unicast prefix-limit maximum {{ peer.max_prefixes }}
set protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }} family inet unicast prefix-limit maximum {{ peer.max_prefixes }}
{% endif %}
{% if peer.enabled == False %}
deactivate protocols bgp group {{ peer.peer_group }} neighbor {{ peer.neighbor_address }}
deactivate protocols bgp group {{ name }} neighbor {{ peer.neighbor_address }}
{% endif %}
{% endfor %}
{% endfor %}
{% endfor %}