Skip to content

Commit

Permalink
ARMv7 Deprecation
Browse files Browse the repository at this point in the history
- cleanup old files
- comment out ARMv7 build args in workflow
- comment out ARMv7 references in install
- update readme
  • Loading branch information
1activegeek committed Jul 9, 2023
1 parent fc419e9 commit 7ef9d4a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 45 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ jobs:
id: prepare
run: |
DOCKER_IMAGE=1activegeek/airconnect
DOCKER_PLATFORMS=linux/amd64,linux/arm/v7,linux/arm64
DOCKER_PLATFORMS=linux/amd64,linux/arm64
# linux/arm/v7 removed as deprecated by ls.io
VERSION=$(curl -s https://api.github.com/repos/philippe44/AirConnect/releases/latest | grep tag_name | cut -d '"' -f 4)
TAGS="--tag ${DOCKER_IMAGE}:dev-${VERSION} --tag ${DOCKER_IMAGE}:dev"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ jobs:
id: prepare
run: |
DOCKER_IMAGE=1activegeek/airconnect
DOCKER_PLATFORMS=linux/amd64,linux/arm/v7,linux/arm64
DOCKER_PLATFORMS=linux/amd64,linux/arm64
# linux/arm/v7 removed as deprecated by ls.io
VERSION=$(curl -s https://api.github.com/repos/philippe44/AirConnect/releases/latest | grep tag_name | cut -d '"' -f 4)
TAGS="--tag ${DOCKER_IMAGE}:${VERSION} --tag ${DOCKER_IMAGE}:latest"
Expand Down
18 changes: 0 additions & 18 deletions Dockerfile.arm64

This file was deleted.

18 changes: 0 additions & 18 deletions Dockerfile.armhf

This file was deleted.

6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ If you like what I've created, please consider contributing:
<br>
<a href="https://ko-fi.com/shawnmix"><img src="https://img.shields.io/badge/Coffee-Buy%20me%20a%20Coffee-grey?style=for-the-badge&logo=buy-me-a-coffee&labelColor=000000"></a>
<br>
## Please note, a breaking change has occurred to the tags used/available. If you were using a `latest-arm64` or similar tag that had the architecture in the name, please remove this so you are updated to the latest.
## ARMv7 HAS BEEN DEPRECATED. IF you'd like to run one of the previous tags of the ARM variant, you can pin to that tag. Unfortunately the base I use, has deprecated ARMv7 support. My only alternative to support is to re-base the entire container which I don't currently have cycles for. I apologize if you were relying on this on those devices.

<br>
# docker-airconnect
AirConnect container for turning Chromecast into Airplay targets
Expand Down Expand Up @@ -80,7 +81,8 @@ Once inside the container, you can use standard config options to run the app as
If you perform any realtime testing, it is suggested to completely restart the container after testing to be sure there are no incompatibilities that arise with running it in daemon mode while also running it interactively.

# Changelog
**2022-11-28:** Some recent updates to handle changes by the original developer in formatting for binary file names. More efficient workflow runs as well. Added in output of tags for AirConnect versions, allowing you to specifically use a specific version of AirConnect.
**2023-07-08:** The LS.io team has officially deprecated building ARMv7 base images. Had to deprecate this support as well. Attempted to comment out in case changes happen in the future to remedy this. <br>
**2022-11-28:** Some recent updates to handle changes by the original developer in formatting for binary file names. More efficient workflow runs as well. Added in output of tags for AirConnect versions, allowing you to specifically use a specific version of AirConnect. <br>
**2022-01-03:** Fixed the multi-arch builds with the new setup on GH actions, migrated to single unified Dockerfile deployment<br>
**2021-12-12:** Modified the builder to use the docker buildx GH actions, and manifest to be just the single tag. Additionally the Binary pull has been moved from startup script, to the actual dockerfile. This results in the images being a point-in-time version of the current airconnect binaries vs always running the latest. `kill` function introduced for the AIRUPNP_VAR/AIRCAST_VAR variables which will stop the appropriate service from running (in case you are not using it).

Expand Down
10 changes: 5 additions & 5 deletions root/etc/cont-init.d/30-install
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ if [ "$ARCH_VAR" == "amd64" ]; then
ARCH_VAR=linux-x86_64
elif [ "$ARCH_VAR" == "arm64" ]; then
ARCH_VAR=linux-aarch64
elif [ "$ARCH_VAR" == "arm" ]; then
ARCH_VAR=linux-arm
# elif [ "$ARCH_VAR" == "arm" ]; then
# ARCH_VAR=linux-arm
fi

echo "Checking for valid arch options"
Expand All @@ -16,9 +16,9 @@ case $ARCH_VAR in
linux-aarch64)
echo "Proceeding with linux-aarch64 arch"
;;
linux-arm)
echo "Proceeding with linux-arm arch"
;;
# linux-arm)
# echo "Proceeding with linux-arm arch"
# ;;
*)
echo "Unrecognized or invalid arch selection, CANCELING INSTALL"
echo "========== FAILURE DETECTED ========="
Expand Down

0 comments on commit 7ef9d4a

Please sign in to comment.