Skip to content

Commit

Permalink
Remove some NewRelic method tracing (#11887)
Browse files Browse the repository at this point in the history
changelog: Internal, Performance, Remove some NewRelic method tracing
  • Loading branch information
mitchellhenke authored Feb 18, 2025
1 parent 064352b commit e2605fb
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 28 deletions.
3 changes: 0 additions & 3 deletions app/models/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
class User < ApplicationRecord
include NonNullUuid

include ::NewRelic::Agent::MethodTracer
include ActionView::Helpers::DateHelper

devise(
Expand Down Expand Up @@ -508,8 +507,6 @@ def send_confirmation_instructions
# no-op
end

add_method_tracer :send_devise_notification, "Custom/#{name}/send_devise_notification"

def analytics
@analytics ||= Analytics.new(user: self, request: nil, session: {}, sp: nil)
end
Expand Down
6 changes: 0 additions & 6 deletions app/presenters/confirmation_email_presenter.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# frozen_string_literal: true

class ConfirmationEmailPresenter
include ::NewRelic::Agent::MethodTracer

def initialize(user, view)
@user = user
@view = view
Expand Down Expand Up @@ -40,8 +38,4 @@ def confirmation_period
private

attr_reader :user, :view

add_method_tracer :initialize, "Custom/#{name}/initialize"
add_method_tracer :first_sentence, "Custom/#{name}/first_sentence"
add_method_tracer :confirmation_period, "Custom/#{name}/confirmation_period"
end
4 changes: 0 additions & 4 deletions app/services/send_sign_up_email_confirmation.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# frozen_string_literal: true

class SendSignUpEmailConfirmation
include ::NewRelic::Agent::MethodTracer

attr_reader :user

def initialize(user)
Expand Down Expand Up @@ -65,6 +63,4 @@ def send_suspended_user_email
def handle_multiple_email_address_error
raise 'sign up user has multiple email address records'
end

add_method_tracer :call, "Custom/#{name}/call"
end
5 changes: 0 additions & 5 deletions config/initializers/new_relic_tracers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,3 @@
add_method_tracer :deliver, "Custom/#{name}/deliver"
add_method_tracer :deliver!, "Custom/#{name}/deliver!"
end

SamlIdp::SignedInfoBuilder.class_eval do
include ::NewRelic::Agent::MethodTracer
add_method_tracer :encoded, "Custom/#{name}/encoded"
end
5 changes: 0 additions & 5 deletions lib/ab_test.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# frozen_string_literal: true

class AbTest
include ::NewRelic::Agent::MethodTracer

attr_reader :buckets,
:experiment_name,
:default_bucket,
Expand Down Expand Up @@ -173,7 +171,4 @@ def ensure_numeric_percentages
def within_100_percent?
valid_bucket_data_structure? && buckets.values.sum <= 100
end

add_method_tracer :bucket, "Custom/#{name}/bucket"
add_method_tracer :percent, "Custom/#{name}/percent"
end
5 changes: 0 additions & 5 deletions lib/mailer_sensitive_information_checker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,4 @@ def self.alert(exception)
raise exception
end
end

class << self
include ::NewRelic::Agent::MethodTracer
add_method_tracer :check_for_sensitive_pii!, "Custom/#{name}/check_for_sensitive_pii!"
end
end

0 comments on commit e2605fb

Please sign in to comment.