Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Open Peeps to 18F Folks #722

Closed
wants to merge 6 commits into from
Closed

Conversation

mitogi
Copy link
Contributor

@mitogi mitogi commented Sep 17, 2024

Changed Open Peeps to 18F Folks. Peeps is the trademarked marshmallow.

Changes proposed in this pull request:

  • Text and style updates

@nateborr
Copy link
Member

@mitogi Is your intent to apply a change to the main branch and deploy it? Currently this PR is set to make a one-word change to the mp-open-peeps-add branch in the 18F repo from the branch with the same name in your fork of the repo.

If so, if you click the Edit button at the top of the PR, you'll see a drop-down that will give you the option to change the base branch of the PR (that is, the branch that will receive the change you're proposing) to main.

If you'd like to pair on making the change, let me know and I'd be happy to!

@mitogi mitogi changed the base branch from mp-open-peeps-add to main September 24, 2024 20:16
Copy link
Member

@igorkorenfeld igorkorenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good – one minor spacing change, and a content change to consider.

content/brand/images.md Outdated Show resolved Hide resolved
content/brand/images.md Outdated Show resolved Hide resolved
@igorkorenfeld igorkorenfeld self-requested a review October 22, 2024 14:05
igorkorenfeld
igorkorenfeld previously approved these changes Oct 22, 2024
Copy link
Member

@igorkorenfeld igorkorenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

Copy link
Member

@igorkorenfeld igorkorenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge when ready!

@michelle-rago
Copy link
Member

Looks good to me, feel free to merge when ready!

Darn. This requires commits to be signed. I don't have that set up. You can merge if you're able, @igorkorenfeld!

@igorkorenfeld
Copy link
Member

Superseded by #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants