This repository has been archived by the owner on Dec 17, 2021. It is now read-only.
Fix some bug risks and code quality issues #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - In `gatherers/gathererabc.py`, `utils/scan_utils.py` and `utils/utils.py`, fix dangerous default argument (mutables) from being passed in methods - In `scanners/sslyze.py`, fix an instance of unnecessary `len()` call being used to check for emptiness of an iterable - In `gatherers/censys.py`, `gatherers/rdns.py` and `utils/scan_utils.py`, make logging calls to lazily evaluate strings Also added a .deepsource.toml configuration file to run Continuous Quality analysis on the repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
gatherers/gathererabc.py,utils/scan_utils.pyandutils/utils.py, fix dangerous default argument (mutables) from being passed in methodsscanners/sslyze.py, fix an instance of unnecessarylen()call being used to check for emptiness of an iterablegatherers/censys.py,gatherers/rdns.pyandutils/scan_utils.py, make logging calls to lazily evaluate stringsThis PR also adds
.deepsource.tomlconfiguration file to run Continuous Quality analysis on the repo with DeepSource. Upon enabling DeepSource, quality analysis will be run on every PR to detect 500+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.DeepSource is a free to use for open-source projects, and is used by teams at NASA, Uber, Slack among many others.
To enable DeepSource analysis after merging this PR, please follow these steps:
You can also look at the docs for more details. Do let me know if I can be of any help!
Cheers,
Sanket
Founder, DeepSource