snapshots inside tests which are marked as xfail are now ignored (#184)

changelog.d/20250202_081752_15r10nk-git_new_defaults.md

@@ -0,0 +1,3 @@
+### Fixed
+
+- snapshots inside tests which are marked as xfail are now ignored (#184)

src/inline_snapshot/pytest_plugin.py

@@ -21,6 +21,7 @@
 from ._code_repr import used_hasrepr
 from ._find_external import ensure_import
 from ._flags import Flags
+from ._global_state import snapshot_env
 from ._global_state import state
 from ._inline_snapshot import used_externals
 from ._rewrite_code import ChangeRecorder
@@ -149,10 +150,17 @@ def pytest_configure(config):
 
 
 @pytest.fixture(autouse=True)
-def snapshot_check():
+def snapshot_check(request):
     state().missing_values = 0
     state().incorrect_values = 0
-    yield
+
+    if "xfail" in request.keywords:
+        with snapshot_env() as local_state:
+            local_state.active = False
+            yield
+        return
+    else:
+        yield
 
     missing_values = state().missing_values
     incorrect_values = state().incorrect_values

tests/test_pytest_plugin.py

@@ -795,3 +795,22 @@ def test_something():
             }
         ),
     )
+
+
+def test_xfail():
+
+    Example(
+        """\
+import pytest
+
+@pytest.mark.xfail
+def test_a():
+    assert 1==snapshot(5)
+"""
+    ).run_pytest(
+        ["--inline-snapshot=fix"],
+        report=snapshot(""),
+        returncode=snapshot(0),
+        stderr=snapshot(""),
+        changed_files=snapshot({}),
+    )