Merge pull request #233 from 10up/fix/upload-message-when-done

fix window title after image uploaded
10up · Jul 9, 2024 · af2dc83 · af2dc83
2 parents 3ec9959 + 1e11156
commit af2dc83
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/js/src/windows-azure-storage-admin.js b/js/src/windows-azure-storage-admin.js
@@ -87,6 +87,8 @@
           window.setTimeout( function () {
             get_upload_progress( item_id, item );
           }, 1000 );
+        } else {
+          $( 'div.media-modal.wp-core-ui' ).find( 'div.media-frame-title > h1' ).text( azureStorageConfig.l10n.uploadReady );
         }
       } ).fail( function () {
         window.setTimeout( function () {

diff --git a/js/windows-azure-storage-admin.js b/js/windows-azure-storage-admin.js
@@ -81,6 +81,8 @@
           window.setTimeout( function () {
             get_upload_progress( item_id, item );
           }, 1000 );
+        } else {
+          $( 'div.media-modal.wp-core-ui' ).find( 'div.media-frame-title > h1' ).text( azureStorageConfig.l10n.uploadReady );
         }
       } ).fail( function () {
         window.setTimeout( function () {

diff --git a/js/windows-azure-storage-admin.min.js b/js/windows-azure-storage-admin.min.js
diff --git a/windows-azure-storage-dialog.php b/windows-azure-storage-dialog.php
@@ -51,13 +51,18 @@
 function windows_azure_storage_dialog_scripts( $hook_suffix ) {
 	$js_ext  = ( ! defined( 'SCRIPT_DEBUG' ) || false === SCRIPT_DEBUG ) ? '.min.js' : '.js';
 	$css_ext = ( ! defined( 'SCRIPT_DEBUG' ) || false === SCRIPT_DEBUG ) ? '.min.css' : '.css';
-	wp_enqueue_script( 'windows-azure-storage-admin', MSFT_AZURE_PLUGIN_URL . 'js/windows-azure-storage-admin' . $js_ext, array(), MSFT_AZURE_PLUGIN_VERSION );
+	wp_enqueue_script( 'windows-azure-storage-admin', MSFT_AZURE_PLUGIN_URL . 'js/windows-azure-storage-admin' . $js_ext, array(), MSFT_AZURE_PLUGIN_VERSION, true );
 	wp_enqueue_style( 'windows-azure-storage-style', MSFT_AZURE_PLUGIN_URL . 'css/windows-azure-storage' . $css_ext, array(), MSFT_AZURE_PLUGIN_VERSION );
-	wp_localize_script( 'windows-azure-storage-admin', 'azureStorageConfig', array(
-		'l10n' => array(
-			'uploadingToAzure' => __( 'Uploading to Azure', 'windows-azure-storage' ),
-		),
-	) );
+	wp_localize_script(
+		'windows-azure-storage-admin',
+		'azureStorageConfig',
+		array(
+			'l10n' => array(
+				'uploadingToAzure' => __( 'Uploading to Azure', 'windows-azure-storage' ),
+				'uploadReady'      => __( 'Attachment details', 'windows-azure-storage' ),
+			),
+		) 
+	);
 }
 
 add_action( 'admin_enqueue_scripts', 'windows_azure_storage_dialog_scripts' );