refactor: untangle data flow structs #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
commented
Mar 25, 2024
| @@ -60,8 +32,6 @@ pub struct EncloneExacts { | |||
| pub join_info: Vec<JoinInfo>, | |||
| pub drefs: Vec<DonorReferenceItem>, | |||
| pub sr: Vec<Vec<Double>>, | |||
| pub fate: Vec<HashMap<String, BarcodeFate>>, // GETS MODIFIED SUBSEQUENTLY | |||
There was a problem hiding this comment.
Not any more, it doesn't! :)
macklin-10x
force-pushed
the
macklin/untangle-data-flow-structs
branch
from
b124b0d to
d25b9b9
Compare
sreenathkrishnan
approved these changes
Mar 29, 2024
Comment on lines
+258
to
+261
| // The original logic for computing this value was based on the confusing | ||
| // assumption that this is always true if self.tcr is false. | ||
| // I've preserved this for now, but this line might make sense to add: | ||
| // assert!(self.bcr); |
There was a problem hiding this comment.
Makes sense! We could use enum instead of two booleans
There was a problem hiding this comment.
Yeah, the logic here was just so odd/implicit that I decided to back away slowly before turning and running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works over the type hierarchy used to pass high-level data around, removing redundancy and tightening up mutation.