-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collapse annotation helper types #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
force-pushed
the
macklin/break-up-annotation
branch
from
March 22, 2024 18:54
8bf9191
to
760494f
Compare
macklin-10x
force-pushed
the
macklin/collapse-annotation-helper-types
branch
from
March 22, 2024 18:55
dcae517
to
f914112
Compare
macklin-10x
force-pushed
the
macklin/break-up-annotation
branch
from
March 29, 2024 04:38
760494f
to
f048159
Compare
macklin-10x
force-pushed
the
macklin/collapse-annotation-helper-types
branch
from
March 29, 2024 04:39
f914112
to
4b954d7
Compare
macklin-10x
force-pushed
the
macklin/break-up-annotation
branch
from
April 2, 2024 04:22
f048159
to
16096b7
Compare
macklin-10x
force-pushed
the
macklin/collapse-annotation-helper-types
branch
from
April 2, 2024 04:23
4b954d7
to
4073a55
Compare
… offset() method.
macklin-10x
force-pushed
the
macklin/collapse-annotation-helper-types
branch
from
April 17, 2024 17:37
4073a55
to
f2f2e12
Compare
sreenathkrishnan
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapses the three intermediate annotation types into a single
Alignment
struct. This was carefully done in a series of systematic steps; this PR may be easier to review commit-by-commit rather than viewing the entire diff as a unit.