[FEATURE] Utiliser PixIcon dans Pix App - Partie 2 (PIX-15468). #11055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiaPena
added
Development in progress
team-acces
team-evaluation
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
AndreiaPena
force-pushed
the
pix-15468-replace-fontawesome-with-pix-icon
branch
from
a74fffe to
1582805
Compare
AndreiaPena
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
team-evaluation
AndreiaPena
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
force-pushed
the
pix-15468-replace-fontawesome-with-pix-icon
branch
from
5a21bb1 to
fb5cbe0
Compare
pix-service-auto-merge
deleted the
pix-15468-replace-fontawesome-with-pix-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Le composant PixIcon existe et les FaIcon peuvent désormais être remplacés.
🎁 Proposition
Utiliser PixIcon
🧦 Remarques
PR de la partie 1 : #10632
🎅 Pour tester
Je manque de connaissance sur les différents scopes pour vérifier visuellement le résultat.
Je laisse donc les deux équipes concernées (@1024pix/team-acces et @1024pix/team-evaluation ) le soin de vérifier 🙇♀️
J'ai séparé en deux commits les deux team :)
Coté Accès :
FormTextfieldde type password est impacté. Il est utilisé sur les anciennes pages de connexion il me semble ET sur la récupération d'un compte mais je n'ai pas connaissance des seeds.Coté Eval : ✅ review faite par la team