Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] 🚚 Déplacement de verify-certification-code-service vers src #11033

Merged

Conversation

yaf
Copy link
Member

@yaf yaf commented Jan 9, 2025

🎄 Problème

Le service de vérification de code de certification est dans le répertoire lib.

🎁 Proposition

Déplacer le service de vérification de code de certification dans le répertoire src

🧦 Remarques

🎅 Pour tester

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@yaf yaf added the team-certif label Jan 9, 2025
@yaf yaf self-assigned this Jan 9, 2025
alexandrecoin
alexandrecoin previously approved these changes Jan 9, 2025
@alexandrecoin alexandrecoin dismissed their stale review January 9, 2025 16:18

Error reviewing

@alexandrecoin
Copy link
Contributor

alexandrecoin commented Jan 9, 2025

Remarque: Ce service ne semble être utilisé que dans le usecase retrieve-last-or-create-certification-course qui se trouve dans le contexte evaluation

De plus, il serait possible de l'injecter via l'index du domaine en question , et non plus via api/lib/domain/usecases/index.js

@yaf yaf force-pushed the migrate-verify-certification-code-service-to-src branch from 5ded23f to 93dd4a8 Compare January 10, 2025 08:58
@yaf yaf force-pushed the migrate-verify-certification-code-service-to-src branch from 93dd4a8 to 819490b Compare January 10, 2025 15:26
@yaf yaf force-pushed the migrate-verify-certification-code-service-to-src branch from 819490b to 168505b Compare January 10, 2025 15:27
@yaf yaf added Func Review OK PO validated functionally the PR 🚀 Ready to Merge and removed 👀 Func Review Needed labels Jan 10, 2025
@pix-service-auto-merge pix-service-auto-merge force-pushed the migrate-verify-certification-code-service-to-src branch from 168505b to 6a69f9c Compare January 10, 2025 15:48
@pix-service-auto-merge pix-service-auto-merge merged commit fd70708 into dev Jan 10, 2025
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the migrate-verify-certification-code-service-to-src branch January 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants