-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Modification des pages de CGU (PIX-15589) #11023
Open
bpetetot
wants to merge
7
commits into
dev
Choose a base branch
from
pix-15589-update-acceptation-page
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
bpetetot
force-pushed
the
pix-15589-update-acceptation-page
branch
2 times, most recently
from
January 8, 2025 16:50
2956478
to
a3bece7
Compare
theotime2005
changed the title
[FEATURE] Modification des pages de CGUs (PIX-15589)
[FEATURE] Modification des pages de CGU (PIX-15589)
Jan 9, 2025
bpetetot
force-pushed
the
pix-15589-update-acceptation-page
branch
9 times, most recently
from
January 9, 2025 17:08
6ebfaf5
to
be7a6d4
Compare
Co-authored-by: Theo <[email protected]> Co-authored-by: Jérémy PLUQUET <[email protected]>
Co-authored-by: Theo <[email protected]> Co-authored-by: Jérémy PLUQUET <[email protected]>
Co-Authored-By: Benjamin Petetot <[email protected]> Co-Authored-By: Jérémy PLUQUET <[email protected]>
Co-authored-by: Benjamin Petetot <[email protected]>
P-Jeremy
force-pushed
the
pix-15589-update-acceptation-page
branch
from
January 10, 2025 09:33
be7a6d4
to
e8adfc3
Compare
P-Jeremy
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Jan 10, 2025
theotime2005
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revue fonctionnelle ok pour moi.
P-Jeremy
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Avec le nouveau versionnement des CGUs Pix Orga, on souhaite changer le design des pages d’acceptation et de gérer le cas des CGUs qui ont évoluées.
🎁 Proposition
Modification de la page d’acceptation des CGU:
pix-orga-terms-of-service-status
accepted
, se connecter à Pix Orgarequested
, afficher le nouveau design de première acceptation des CGUs (voir maquette)update-requested
, afficher le nouveau design d'évolution des CGUs (voir maquette - uniquement changement de texte)L’URL des CGUs Pix Orga en utilisant
pix-orga-terms-of-service-document-path
:Versions actuelles:
🧦 Remarques
🎅 Pour tester
Test 1
/api/users/{id}/pix-orga-terms-of-service-acceptance
doit fonctionner avec l’ancien modèle des CGUs et enregistrer les CGUsTest 2 (Nécessite de créer le legal document via le script en amont)
/api/users/{id}/pix-orga-terms-of-service-acceptance
doit fonctionner avec le nouveau modèle des CGUs et enregistrer les CGUsTest 3 (Nécessite de créer le legal document via le script en amont)
/api/users/{id}/pix-orga-terms-of-service-acceptance
doit fonctionner avec le nouveau modèle des CGUs et enregistrer les CGUs