[FEATURE] Configuration de l'oralisation par élève pour les écoles (PIX-13753) #10346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaf
changed the title
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yaf
added
Development in progress
👀 Tech Review Needed
🎒👧🏽👦🏾 PIX JUNIOR
👀 Func Review Needed
yaf
changed the title
aurelie-crouillebois
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
50cbb2b to
08950a3
Compare
rouxxi
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
d49ca0c to
cde9df8
Compare
yaf
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
2 times, most recently
from
92a7552 to
faa0314
Compare
aurelie-crouillebois
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
faa0314 to
afa9365
Compare
rouxxi
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
afa9365 to
2f81124
Compare
yaf
changed the title
aurelie-crouillebois
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
9b4775f to
35dbfe8
Compare
rouxxi
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
2 times, most recently
from
9e9bf65 to
86a5e7b
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yaf
added
Func Review OK
machestla
approved these changes
Oct 25, 2024
...anization-learner/integration/infrastructure/organization-learner-feature-repository_test.js
Show resolved
Hide resolved
...anization-learner/integration/infrastructure/organization-learner-feature-repository_test.js
Show resolved
Hide resolved
| }; | ||
|
|
||
| async function _addOralizationInformations({ |
There was a problem hiding this comment.
Suggestion: déplacer cette logique dans le repository pour qu'il aille chercher des infos supplémentaires et les mette dans le model. (non-blocking)
There was a problem hiding this comment.
J'ai l'impression que ça ajouterait de la logique métier dans le code du repo, ça me fait bizarre. Nous pourrions extraire ces bouts de code dans un service éventuellement, tu en penses quoi ?
Ou bien par injection du décorateur 🤔 nous avons déjà fait ça dans un autre usecase, pour pixJunior, dans l'API je crois ...
There was a problem hiding this comment.
je vais pousser comme ça pour le moment, en ajoutant un commentaire dans le code qui pointe vers cette conversation...
ThomasBazin
approved these changes
Oct 25, 2024
api/db/migrations/20241016095050_add-oralization-feature-to-sco-1d-organizations.js
Outdated
Show resolved
Hide resolved
...ase-builder/factory/prescription/organization-learners/build-organization-learner-feature.js
Outdated
Show resolved
Hide resolved
...anization-learner/integration/infrastructure/organization-learner-feature-repository_test.js
Show resolved
Hide resolved
Co-Authored-By: Aurélie Crouillebois <[email protected]>
Co-Authored-By: Aurélie Crouillebois <[email protected]>
Co-Authored-By: Gwenvaël Laskar <[email protected]> Co-Authored-By: Aurélie Crouillbois <[email protected]>
Co-authored-by: <[email protected]>
Co-authored-by: rouxxi <[email protected]>
Co-Authored-By: Aurélie Crouillebois <[email protected]>
Co-Authored-By: Aurélie Crouillebois <[email protected]>
Co-authored-by: Marie-Hélène Rots <[email protected]>
…o-1d-organizations.js Co-authored-by: Thomas Bazin <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-13753-add-oralizing-feature-for-mission-learner
branch
from
604152f to
874644f
Compare
pix-service-auto-merge
deleted the
pix-13753-add-oralizing-feature-for-mission-learner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
L'oralisation ne peut pas toujours être utilisée (trop de bruit dans une classe où il y aurait plusieurs ordis sans casque dans une même pièce par exemple).
🤖 Proposition
Afficher si l'option d'oralisation a été activée ou désactivée pour chaque élève d'une classe.
🌈 Remarques
Nous avons utilisé l'interface générique (lié aux imports) pour faire ces modifications. Nous avons dû ajouter des tests pour masquer les informations de campagnes.
💯 Pour tester
Afficher les participants dans une organisation SCO-1D. Tous les participants ont la colonne "Lecture de la consigne" à "Désactivée" sauf 3 élèves dont le prénom contient 'oralisé' pour lesquels la feature est associée dans les seeds.