Add ERC721C capability to ERC721Items #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this feature, we must also deploy and configure the EOARegistry, CreatorTokenTransferValidatorConfiguration and CreatorTokenTransferValidator. These exist on some networks already and are used by default, but we may want to provide our own implementation as they are owned by limit break and we may require different defaults.
Security level docs.
The default security level is level 3.
To allow Sequence Wallets to function the same as EOAs for security levels 5 and 6 we must whitelist the wallet code hash. This is an imperfect solution as it will allow other proxy contracts through. It also allows sequence wallets to act as operators on transfers which is unintended for these levels. Failing test are intentionally committed to highlight the issue.
We cannot whitelist the code hash for all security levels as this breaks level 4 policies.
We should consider whether we upgrade all ERC721Items contract to support ERC721C. Level 1 is effectively the same as existing functionality for ERC721Items. However, this change adds significant overhead for transfers.