Payments - Receive on chain payments for off chain items (#13) #111
ScreamingHawkAnnotations
16 warnings
|
Install dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Install dependencies
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Solidity lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Solidity lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Solidity lint:
src/payments/PaymentCombiner.sol#L18
Variable name must be in mixedCase
|
|
Solidity lint:
src/payments/Payments.sol#L57
Avoid making time-based decisions in your business logic
|
|
Solidity lint:
src/proxies/openzeppelin/BeaconProxy.sol#L8
global import of path @openzeppelin/contracts/proxy/beacon/IBeacon.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/BeaconProxy.sol#L9
global import of path @openzeppelin/contracts/proxy/Proxy.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/BeaconProxy.sol#L10
global import of path @openzeppelin/contracts/proxy/ERC1967/ERC1967Upgrade.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/ERC1967Proxy.sol#L8
global import of path @openzeppelin/contracts/proxy/Proxy.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/ERC1967Proxy.sol#L9
global import of path @openzeppelin/contracts/proxy/ERC1967/ERC1967Upgrade.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/TransparentUpgradeableProxy.sol#L12
global import of path ./ERC1967Proxy.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Solidity lint:
src/proxies/openzeppelin/TransparentUpgradeableProxy.sol#L93
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Solidity lint:
src/proxies/openzeppelin/TransparentUpgradeableProxy.sol#L181
Provide an error message for require
|
|
Foundry tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Foundry tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|