Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Workspace: Pnpm as Dependency Manager #119

Merged
merged 23 commits into from
Jan 1, 2024
Merged

(chore) Workspace: Pnpm as Dependency Manager #119

merged 23 commits into from
Jan 1, 2024

Conversation

0xTheProDev
Copy link
Owner

@0xTheProDev 0xTheProDev commented Dec 25, 2023

Use Pnpm as dependency manager from here on out. Update GitHub CI workflows to accomodate the changes.

Fixes: #118

Pull Request Guidelines

This documentation contains a set of guidelines to help you with the pull request process.

Please ensure you adhere to every item in this list.

  • As a Contributor:

    • The PR should have commits that follows the standards mentioned here
    • The PR should only be made against existing issues. If a certain issue does not exist; kindly open a thread in Discussion.
    • For a corresponding issue, add either Fixes #1234 or Updates #1234, where 1234 refers to that issue id.
    • Ensure that pre-commit hooks are running in your local setup.
    • Add or modify the tests (Unit/Integration) for the code changes.
    • Make sure that all existing test cases are passing and have net positive code coverage.

    Note: The PR will be squashed before merging, make sure to add all relevant details on the first commit or inform the reviewer any further information if needed.

  • As a Maintainer:

    • Ensure the PR is accurate representation of the issue it refers to.
    • Ensure the issue is a part of current Sprint/Milestone or add as such.
    • Add proper assigne to the PR and mark Release Version.
    • Remember to add reference to PR, along with Issue, in the Changelog for that particular release.

Use Pnpm as dependency manager from here on out. Update GitHub CI workflows to accomodate the changes.

Fixes: #118
Signed-off-by: Progyan Bhattacharya <[email protected]>
@0xTheProDev 0xTheProDev self-assigned this Dec 25, 2023
… fixup! fixup! fixup! (chore) Workspace: Pnpm as Dependency Manager
… fixup! fixup! fixup! fixup! (chore) Workspace: Pnpm as Dependency Manager
… fixup! fixup! fixup! fixup! fixup! (chore) Workspace: Pnpm as Dependency Manager
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf7934b) 95.16% compared to head (b724d25) 94.66%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   95.16%   94.66%   -0.50%     
==========================================
  Files          39       37       -2     
  Lines        2480     2100     -380     
  Branches      331      282      -49     
==========================================
- Hits         2360     1988     -372     
+ Misses        120      112       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xTheProDev 0xTheProDev merged commit f1decc6 into main Jan 1, 2024
8 of 9 checks passed
@0xTheProDev 0xTheProDev deleted the issue/118 branch January 1, 2024 08:00
Repository owner locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Dependency Management to pnpm
2 participants