Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:fix typo #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/contracts/guides/01-L1-Contracts.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ To run deployment scripts or any other custom scripts, use:
yarn hardhat run <script-path> --network <chosen-network>
```

Scripts are located in the scipts folder.
Scripts are located in the scripts folder.

## Deployment with Hardhat-Deploy

Expand Down Expand Up @@ -79,15 +79,15 @@ PRIVATE_KEY: Your Ethereum private key, used for transactions and contract deplo

## Building a new strategy

You can build a new strategy building contract inheriting from StrategyBase.sol, you'll need to override virtual methods and add potential additional logic related to the strategy you want to build. 2 built strategies are proposed as exemples savingDai.sol and uniswapV3.sol
You can build a new strategy building contract inheriting from StrategyBase.sol, you'll need to override virtual methods and add potential additional logic related to the strategy you want to build. 2 built strategies are proposed as examples savingDai.sol and uniswapV3.sol

## Deploying pooling manager and adding new strategies

1. Fill the scripts/config.ts with deployed pooling manager on L2 and deploy the l1 poolingManager using hardhat-deploy. Add this new deployed address in the config.ts

2. (only for goerli): deploy mock contract for your strategy if it is not deployed on this network like it's done with saving dai(cc deploy/savingDai.ts). Or setup the environment of the strategy if it exists like uniswapV3 where you need to deploy a new pool and add liquidity (cc scripts/deployUniPool.ts and scripts/initAndAddLiq.ts)

3. Add the required addresses in the config.ts for your strategy (uniV3Router for exemple)
3. Add the required addresses in the config.ts for your strategy (uniV3Router for example)

4. Deploy the strategy using hardhat-deploy

Expand Down
4 changes: 2 additions & 2 deletions docs/contracts/guides/02-L2-Contracts.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ To create a test account run the script `./account.sh`. Follow the instructions
## ENVs
Update the ENVs inside the .env file
```plaintext
STARKNET_NETWORK= network goerli ot mainnet
STARKNET_NETWORK= network goerli or mainnet
ACCOUNT_ADDRESS= account address
ACCOUNT_PK= account provate key
ACCOUNT_PK= account private key
```

## Declare With Starkli
Expand Down