Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable erc20/goverance in ci #762

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

kyu-c
Copy link
Contributor

@kyu-c kyu-c commented Nov 14, 2023

Description

  • As ZRXToken.sol does not compile with the latest forge and currently CI is broken at head.
  • Temporarily disable erc20/governance in CI

To reproduce:

cd contracts/erc20
forge build --contracts=src/ZRXToken.sol

Testing instructions

Types of changes

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kyu-c kyu-c marked this pull request as ready for review November 14, 2023 21:32
@kyu-c kyu-c requested a review from dekz as a code owner November 14, 2023 21:32
@kyu-c kyu-c force-pushed the kyu/skip-erc20-ci branch from 1aca286 to 3bea071 Compare November 14, 2023 21:52
@kyu-c kyu-c changed the title Temporarily disable erc20 in ci Temporarily disable erc20/goverance in ci Nov 14, 2023
@kyu-c kyu-c merged commit 5207565 into development Nov 15, 2023
1 check passed
@kyu-c kyu-c deleted the kyu/skip-erc20-ci branch November 15, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants