Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use miden-base's next #730

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

chore: Use miden-base's next #730

wants to merge 4 commits into from

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Feb 12, 2025

This also requires a specific branch from the node for now, because the node was also still using 0.7.

@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 12, 2025
Comment on lines 1 to 2
# Configuration settings for running integration tests.
# Adjust these values to modify how the tests are executed, such as using a remote RPC endpoint instead of a local one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments seem to have been deleted, probably because the generated config file didn't have them. We should re-add them as they explained that this was the configs for the tests.

Copy link
Collaborator

@TomasArrachea TomasArrachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants