Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pol upgrade review #10

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Fix/pol upgrade review #10

merged 10 commits into from
Aug 22, 2024

Conversation

ethyla
Copy link
Contributor

@ethyla ethyla commented Aug 20, 2024

No description provided.

@simonDos simonDos requested a review from web3security August 22, 2024 11:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@simonDos
Copy link
Member

simonDos commented Aug 22, 2024 •
edited
Loading

merged feat/pol to resolve conflict in StakeManager
Ready for final approval from @web3security

web3security
web3security approved these changes Aug 22, 2024
View reviewed changes
Copy link

@web3security web3security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot

web3security
web3security reviewed Aug 22, 2024
View reviewed changes
Copy link

@web3security web3security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would likely break forceUnstake for validators whose id < 8. Please check.

@simonDos simonDos merged commit 753a269 into feat/pol Aug 22, 2024
2 checks passed
@simonDos simonDos deleted the fix/polUpgradeReview branch August 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web3security web3security web3security approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethyla @simonDos @web3security