-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVT-1200 configure pipeline for polycli docker deployment #189
Conversation
e323747
to
518ed1e
Compare
163d73b
to
27635b4
Compare
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
Co-authored-by: Léo Vincent <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few nits :)
have you tried installing the polycli
debian pkg and tested if it works well btw?
Co-authored-by: Léo Vincent <[email protected]>
@leovct ready for review again 😎 tested both docker and debian 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update the Dockerfile
and it should be ready to be merged! 🥳
c779d26
to
0cbf33e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
CI pipeline implemented to deploy for docker and APT
test docker : https://www.notion.so/polygontechnology/docker-install-artifact-registry-029697d8dd734241bf8762093fc5f36e?pvs=4
test apt: https://github.com/maticnetwork/polygon-devnets/pull/192/files#diff-3dbac6e0aed201ffeda73ba9a32923d2900d7550deb0a1b4f1ed4277f1d75a8eR85-R97