Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVT-1200 configure pipeline for polycli docker deployment #189

Merged
merged 23 commits into from
Jan 25, 2024

Conversation

@gatsbyz gatsbyz changed the title configure pipeline for polycli docker deployment DVT-1200 configure pipeline for polycli docker deployment Jan 17, 2024
@gatsbyz gatsbyz force-pushed the jesse/pipeline-deploy branch from e323747 to 518ed1e Compare January 19, 2024 14:31
@gatsbyz gatsbyz force-pushed the jesse/pipeline-deploy branch from 163d73b to 27635b4 Compare January 21, 2024 16:23
@gatsbyz gatsbyz requested a review from a team January 22, 2024 18:43
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few nits :)

have you tried installing the polycli debian pkg and tested if it works well btw?

@gatsbyz gatsbyz requested a review from leovct January 23, 2024 23:04
@gatsbyz
Copy link
Contributor Author

gatsbyz commented Jan 23, 2024

@leovct ready for review again 😎

tested both docker and debian 🙂

Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update the Dockerfile and it should be ready to be merged! 🥳

#189 (comment)

@gatsbyz gatsbyz requested a review from leovct January 24, 2024 15:04
@gatsbyz gatsbyz force-pushed the jesse/pipeline-deploy branch from c779d26 to 0cbf33e Compare January 24, 2024 16:18
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gatsbyz gatsbyz merged commit 8439087 into main Jan 25, 2024
8 checks passed
@gatsbyz gatsbyz deleted the jesse/pipeline-deploy branch January 25, 2024 14:31
@leovct leovct mentioned this pull request Feb 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants