feat: protect ssender nonce #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaubennassar
approved these changes
Sep 9, 2024
Stefan-Ethernal
approved these changes
Sep 9, 2024
sequencesender/sequencesender.go
Outdated
| @@ -131,6 +132,9 @@ func New(cfg Config, etherman *etherman.Client, txBuilder txbuilder.TxBuilder) ( | |||
|
|
|||
| // Start starts the sequence sender | |||
| func (s *SequenceSender) Start(ctx context.Context) { | |||
| s.nonceMutex.Lock() | |||
There was a problem hiding this comment.
WDYT if we lock only this critical section?
s.currentNonce, err = s.etherman.CurrentNonce(ctx, s.cfg.L2Coinbase)
if err != nil {
log.Fatalf("failed to get current nonce from %v, error: %v", s.cfg.L2Coinbase, err)
} else {
log.Infof("current nonce for %v is %d", s.cfg.L2Coinbase, s.currentNonce)
}There was a problem hiding this comment.
Yes, but honestly this is the Start function. It will never be executed in parallel and it is not even needed to protect that variable in this function. But it is ok for me to just protect in that section. I will do the change.
vcastellm
approved these changes
Sep 9, 2024
|
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Sep 17, 2024
* feat: protect ssender nonce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protects sequence sender nonce using a mutex, to avoid issues detected in parallel mode.