-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce the CLI and build workflows #4
Conversation
f44d3b5
to
b1c32af
Compare
8d06c3f
to
070f051
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I disregard the rust files, since I am not in rust yet (and I know you just pushed some base work to continue future work), this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I need to do something special to build this code, not being familiar with the existing code at all but cargo check
or cargo build
gives me the following error
error: failed to run custom build command for `cdk v0.1.0 (/Users/ben/dev/cdk/crates/cdk)`
Caused by:
process didn't exit successfully: `/Users/ben/dev/cdk/target/release/build/cdk-b8965ac9ee75bf2c/build-script-build` (exit status: 101)
--- stdout
cargo:rerun-if-changed=*.go
--- stderr
thread 'main' panicked at crates/cdk/build.rs:29:10:
Failed to execute make command: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...`
Either there's an issue or I need some build instructions :)
@begmaroman the base image now is based on Debian so we need to use golang default image that it's based on debian instead of alpine, binaries are not compatible because the build toolchain is different between them. |
Yes, some build instructions are needed, but basically it tries to build go code first using a cargo buildscript, so it has the Could it be that you don't have Go build toolchain installed? |
Go is installed. v1.22.5 to be specific |
0e0692f
to
806db48
Compare
Use golang image based on Debian
Fix warnings
…n' into vcastellm/run-erigon
806db48
to
aaefb4c
Compare
Issue should be fixed now @muursh, can you try again? |
e55329a
to
87b7561
Compare
…n' into vcastellm/run-erigon
Yep builds now. I'll aim to review today/tomorrow |
|
* feat: introduce the CLI and build workflows * fix: fixed dockerfile Use golang image based on Debian * fix: default config * fix: paths Fix warnings * fix: report better errors * fix: make file OS and make path * refactor: simplify, trim and remove defaults * refactor: do not depend on external testing scripts * fix: conversion of banana sequence * fix: opinionate on CI --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: begmaroman <[email protected]>
This is the first PR introducing the CLI to handle configuration and execution of the different components of the system. In this PoC of the CLI it's only capable of running
cdk-node
as a subprocess and accept 2 configuration files:Also introduce the necessary workflows to build and release docker images to docker repositories compiling and including these elements.
e2e-testing
I've simplified a lot here, if we're testing in local, it's assumed that the developer will have a correct environment running, it's opinionated in the sense that it's required to have
kurtosis-cdk
installed and checked-out on the version you want to try. Similar to having docker installed on your system.Also, there are a lot of defaults now so we don't need to set them.
Reviewer: @goran-ethernal