Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/integration test in CI #11

Closed
wants to merge 10 commits into from
Closed

Feature/integration test in CI #11

wants to merge 10 commits into from

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Jul 1, 2024

Description

This PR integrates tests into the CI pipeline using a Kurtosis instance.

@rachit77 rachit77 requested a review from vcastellm July 1, 2024 15:49
@rachit77 rachit77 self-assigned this Jul 1, 2024
@rachit77 rachit77 changed the title Integration test in CI Feature/integration test in CI Jul 2, 2024
vcastellm
vcastellm approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat!

@vcastellm vcastellm requested a review from arnaubennassar July 3, 2024 16:02
@vcastellm
Copy link
Contributor

Would be great to think a way to run the same in local, a make command.

arnaubennassar
arnaubennassar requested changes Jul 3, 2024
View reviewed changes
test/ethtransfer_test.go Outdated Show resolved Hide resolved
@vcastellm vcastellm mentioned this pull request Jul 4, 2024
Closed
@vcastellm vcastellm mentioned this pull request Jul 14, 2024
Closed
@rachit77 rachit77 changed the base branch from main to develop July 22, 2024 12:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

vcastellm
vcastellm reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to use cdk-erigon kurtosis setup

vcastellm
vcastellm requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for integration of monorepo

@rachit77 rachit77 closed this Nov 19, 2024
@rachit77 rachit77 deleted the rachit/intergration_tests branch November 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm requested changes

@arnaubennassar arnaubennassar arnaubennassar approved these changes

Assignees

@rachit77 rachit77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachit77 @vcastellm @arnaubennassar @rebelArtists