Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mcp tools + bedrock #328

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

edisontim
Copy link
Contributor

Merges #213 and #318 together. Refactored #318 to have a wrapper for the API

@edisontim edisontim changed the title Feat: mcp tools bedrock feat: mcp tools + bedrock Feb 28, 2025
@0xMochan
Copy link
Contributor

Hey, I appreciate all of the support in the issues and PRs. I understand there's a lot of excitement of getting MCP integrated with rig as it's something we are working on actively. It's very unlikely a PR this large will be able to get merged in as it touches wayy too many aspects of the code and bundles too many features for it to reasonable be reviewed in a timely manner.

However, I think there's a lot of good work and ideas here and I'll see if there's a way we can re-leverage the work put here so I'll take some time to study the efforts presented here. I'll also get a milestone / epic going that details the planned tool rework and mcp additions so that there's a clear POV presented to the wider rig community.

@edisontim
Copy link
Contributor Author

It's very unlikely a PR this large will be able to get merged in as it touches wayy too many aspects of the code and bundles too many features for it to reasonable be reviewed in a timely manner.

To be honest there's not that much, just code duplication because of different providers. I can establish a list of the different changes I made here. Or arrange a call to explain in detail why I think they're important.

It's a bit frustrating because I've had a PR open for multiple of these changes since December..

I think the MCP is a good idea to have an in-house tool but in the meantime, why not merge my additions? It's not invasive at all and I'm sure a lot of people need them as they're getting very popular

@@ -27,15 +27,16 @@ rig-derive = { version = "0.1.0", path = "./rig-core-derive", optional = true }
glob = "0.3.1"
lopdf = { version = "0.35.0", optional = true }
rayon = { version = "1.10.0", optional = true }
mcp_client_rs = { git = "https://github.com/edisontim/mcp_client_rust", branch = "ref/cleanup", default-features = false }
Copy link

@snowmead snowmead Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there plans to use the official MCP rust-sdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants