Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deepseek message to remove dependencies with openai #283

Merged

Conversation

carlos-verdes
Copy link
Contributor

No description provided.

@carlos-verdes
Copy link
Contributor Author

@cvauclair @0xMochan do you mind taking a look into this one?

@joshua-mo-143 joshua-mo-143 requested review from joshua-mo-143 and removed request for joshua-mo-143 February 10, 2025 10:03
@cvauclair cvauclair added this to the 2025-02-24 milestone Feb 10, 2025
Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wanted to check up on the index field you are adding.

@carlos-verdes carlos-verdes force-pushed the feature/deepseek-refactor-message branch from 07767cf to 97448c4 Compare February 11, 2025 07:19
@carlos-verdes
Copy link
Contributor Author

@0xMochan applied changes so current PR only affects DeepSeek code

Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test and merge

@0xMochan 0xMochan merged commit 530a327 into 0xPlaygrounds:main Feb 12, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants