Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fastembed integration #268

Merged

Conversation

joshua-mo-143
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 commented Feb 4, 2025

Closes #228

We may want to add other things like SparseModel in the future. However, this PR aims to serve as a starting point for the integration so this is somewhat out of scope (for the PR).

Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to run locally, looks pretty solid and straightforward

  • imo rig-fastembed as the example name is confusing, can it be renamed to like local_embeddings or vector_search, etc.
  • update README.md w/ new logo

I agree with the SparseModel suggestion

Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, pretty awesome crate 🔥.
Mergable after failing tests.

@joshua-mo-143
Copy link
Contributor Author

Merging as the tests all pass

@joshua-mo-143 joshua-mo-143 merged commit e86d1b4 into 0xPlaygrounds:main Feb 5, 2025
5 checks passed
This was referenced Feb 5, 2025
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: fastembed-rs integration
2 participants