chore: Improved test assertion style for better readability #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved test assertion style for better readability and debugging
|
Hello, thanks for this PR! This will not got merged until all of our CI passes. it also might be apt to rebase with main even if there are no conflicts, thanks! There are also a lot of places where we could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced
assert!(expected == actual)withassert_eq!(expected, actual)in the test. While both work,assert_eq!is more idiomatic in Rust as it provides better output for debugging by automatically displaying the values when the assertion fails.p.s. Change improves the readability and overall quality of the tests.