-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support together AI #230
feat: support together AI #230
Conversation
@cvauclair Could you please review this change set? |
Hi @threewebcode , thanks for opening this PR! I'll be having a look over today/tomorrow. |
@joshua-mo-143 Please help review the codes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like the basic example works, which is good.
Can you please fix your tool/embedding implementation? It looks like trying to switch in the together client on the embedding and tool examples totally breaks the examples
|
@joshua-mo-143 Thanks for your kind feedback. I updated codes and please help review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is some kind of error with trying to use this PR with tools. Together just returns str.replace() is not a function
- don't suppose you have any insight into this?
Otherwise lgtm
Can you remove your current code directory and try it again after cloning it from scratch ? |
Still doesn't work. I had a thought: since the To fix this you'll probably need to write your own message struct that implements The resulting API error can be found below: Error: CompletionError: ProviderError: {
"id": "91368a894cbd3634",
"error": {
"message": "Template error: (unknown path)\n TypeError: str.replace is not a function",
"type": "invalid_request_error",
"param": "messages",
"code": null
}
} |
I merged the latest codes from main branch and rerun the examples code. There is no error here.
By the way, how to reproduce your error? |
I added tool example and you can have a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - thanks for your hard work on this PR!
Together AI: https://docs.together.ai/docs/introduction
Example execution: