Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

桁数に応じて座標を設定できるように変更 #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdondonr
Copy link

Game_Balloon_Combo_Number_X,Game_Balloon_Combo_Number_Yを削除し、新たに

  • Game_Balloon_Combo_Number_1digit_X,Game_Balloon_Combo_Number_1digit_Y (一桁)
  • Game_Balloon_Combo_Number_2digit_X,Game_Balloon_Combo_Number_2digit_Y (二桁)
  • Game_Balloon_Combo_Number_3digit_X,Game_Balloon_Combo_Number_3digit_Y (三桁)
    を追加しました

1000コンボ以上のGame_Balloon_Combo_Number_Ex_X,Game_Balloon_Combo_Number_Ex_Yは変更されていません

@0auBSQ
Copy link
Owner

0auBSQ commented Oct 21, 2024

Hello, thank you for your contribution!
Here few additions I would request:

  • To avoid breaking legacy on skins, can you handle "Game_Balloon_Combo_Number_X" as "Game_Balloon_Combo_Number_1digit_X" ? Additionally, if Game_Balloon_Combo_Number_2digit_X and/or Game_Balloon_Combo_Number_3digit_X are missing please use the Game_Balloon_Combo_Number_X value so older skins doesn't require a mandatory update
  • On CActImplComboBalloon.cs there are lots of repetition in the code and it feels to heavy for what it does, please store the number on a temporary variable using the number condition instead in order to call this.t小文字表示 only once

@ExpedicHabbet
Copy link
Contributor

大変申し訳ございませんが、SimpleStyle は https://github.com/OpenTaiko/OpenTaiko-Skins に移動しました。そちらでSimpleStyleに関する何かの編集を続けてください。
I am very sorry to mention that SimpleStyle has been moved to https://github.com/OpenTaiko/OpenTaiko-Skins. Please continue to edit anything about SimpleStyle there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants