Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] bump rust version and sanitize feature flags from vendor #312

Merged
merged 9 commits into from
Aug 22, 2024
Merged

[deps] bump rust version and sanitize feature flags from vendor #312

merged 9 commits into from
Aug 22, 2024

Conversation

sirouk
Copy link
Contributor

@sirouk sirouk commented Aug 20, 2024 •
edited by 0o-de-lally
Loading

  • feature flags with 'testing' were hardcoded in vendor, fixed now in diem
  • cleanup each crate toml moving all features to workspace
  • updates diem upstream which also removes vdf natives and 'testing' features.
  • bumps rust version (1.78.0 produces a clean lockfile that doesn't need to be patched manually).

@0o-de-lally 0o-de-lally force-pushed the remove-toml-feature-flags branch from 540a178 to c42227f Compare August 20, 2024 17:27
@0o-de-lally 0o-de-lally changed the title Remove toml feature flags [deps] sanitize feature flags from vendor Aug 20, 2024
@0o-de-lally 0o-de-lally changed the title [deps] sanitize feature flags from vendor [deps] bump rust version and sanitize feature flags from vendor Aug 20, 2024
@0o-de-lally 0o-de-lally force-pushed the remove-toml-feature-flags branch from bb1fcb9 to ee2e10b Compare August 21, 2024 14:01
@0o-de-lally 0o-de-lally force-pushed the remove-toml-feature-flags branch from 45bd47b to 5ee161c Compare August 21, 2024 15:13
sirouk
sirouk commented Aug 22, 2024
View reviewed changes
Copy link
Contributor Author

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sirouk sirouk merged commit b7aaed3 into 0LNetworkCommunity:main Aug 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboreham dboreham dboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirouk @dboreham @0o-de-lally