Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to have dynamic extensions? #91

Open
mcki0127 opened this issue May 12, 2021 · 3 comments
Open

Is it possible to have dynamic extensions? #91

mcki0127 opened this issue May 12, 2021 · 3 comments

Comments

@mcki0127
Copy link

Is there a way to have dynamic extensions in the configuration rather than hard-coding png or jpg? I need to handle both.

@zxbodya
Copy link
Owner

zxbodya commented May 12, 2021

Currently it is not supported. The reason is that extension in from configuration is used for url generation.

It should be possible to add support for this. That likely to be not very big change, I think it might be something like:

  • column in gallery_image table to store the extension
  • updates for upload logic to actually save the extension in and use it when saving/resizing images
  • update to url/file name generation to use extension from the table

@mcki0127
Copy link
Author

Ok, I might give it a go. I'm surprised this hasn't been requested already. Thanks for your response.

@mcki0127
Copy link
Author

Would you care to have a look at this and see if you might want to merge it?
mcki0127@8b45dcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants