Better support for locally installed tools #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should use |
|
Hey, @zwilias, can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--elm-testarg was only working with absolute paths, and a locally installed copy ofelmwouldn't work at all.Using
path.resolveseemed like a pretty straightforward fix forelm-test, but then I realized the default value for the arg was"elm-test", which is definitely not meant to be resolved as a relative path. I'm not sure what the cleanest way to approach this would be, but I took the perspective that anyone setting it to something other than the default is most likely to be using a path, not another name meant to be resolved by Node, so we can just resolve the value as a relative path if it's not the default value.For
elm, I noticed in #20 that @zwilias had recommended usingnpm-which, and that did the trick nicely.I've not added tests because it's getting late and I'm just trying to get this working for my project and I wasn't actually totally sure how to test the
elmone anyway. I'd love any guidance on this.Resolves #45