From fbc5adca58c5e3bd33d33a06a3bbc27103749b2c Mon Sep 17 00:00:00 2001 From: Gal Szkolnik Date: Fri, 8 Dec 2023 11:34:03 -0500 Subject: [PATCH 1/3] Add units and improve descriptions * Add min-max to descriptions when not covered by min/max values. * Add units NOTE: per style guide, 0-99 should not be accepted as percent, however, in this particular case (except Dimmer Level), percent is percent humidity, and values are absolute and not a relative range, thus I added % as units. Based on ST814 Everspring Manual. https://usermanual.wiki/Everspring-Industry-Co/ST814-2105971.pdf Alternative searches: * https://www.google.com/search?q=filetype%3Apdf+"Everspring"+"ST814"+"Temperature%2FHumidity"+"inclusion%2Fexclusion" * https://www.bing.com/search?q=filetype%3Apdf%20%22Everspring%22%20%22ST814%22%20%22Temperature%2FHumidity%22%20%22inclusion%2Fexclusion%22 --- .../config/config/devices/0x0060/st814.json | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/packages/config/config/devices/0x0060/st814.json b/packages/config/config/devices/0x0060/st814.json index 5babc57f4f4c..4f141178d7ad 100644 --- a/packages/config/config/devices/0x0060/st814.json +++ b/packages/config/config/devices/0x0060/st814.json @@ -30,6 +30,7 @@ "#": "1", "label": "Dim Level Sent via Basic Set", "description": "The dim level sent to a lamp module upon activation: (0) Off; (1)-(99) Dim Level", + "unit": "Brightness Level", "valueSize": 1, "minValue": 0, "maxValue": 99, @@ -44,7 +45,8 @@ { "#": "2", "label": "Temperature Trigger ON Value", - "description": "Temperature level when a ON command is sent out. Set to 99 to disable.", + "description": "Temperature level when a ON command is sent out. -20°..50° or 99 to disable.", + "unit": "°", "valueSize": 1, "minValue": -20, "maxValue": 99, @@ -59,7 +61,8 @@ { "#": "3", "label": "Temperature Trigger OFF Value", - "description": "Temperature level when a OFF command is sent out. Set to 99 to disable.", + "description": "Temperature level when a OFF command is sent out. -20°..50° or 99 to disable.", + "unit": "°", "valueSize": 1, "minValue": -20, "maxValue": 99, @@ -74,7 +77,8 @@ { "#": "4", "label": "Humidity Trigger ON Value", - "description": "Humidity level when a ON command is sent out. Set to 99 to disable.", + "description": "Humidity level when a ON command is sent out. 20%..90%, or 99 to disable.", + "unit": "%", "valueSize": 1, "minValue": 20, "maxValue": 99, @@ -89,7 +93,8 @@ { "#": "5", "label": "Humidity Trigger OFF Value", - "description": "Humidity level when a OFF command is sent out. Set to 99 to disable.", + "description": "Humidity level when a OFF command is sent out. 20%..90%, or 99 to disable.", + "unit": "%", "valueSize": 1, "minValue": 20, "maxValue": 99, @@ -105,6 +110,7 @@ "#": "6", "label": "Auto Report Time", "description": "Sets the time interval when a sensor report is sent", + "unit": "minutes", "valueSize": 2, "minValue": 0, "maxValue": 1439, @@ -120,6 +126,7 @@ "#": "7", "label": "Auto Report Temperature", "description": "Sets the temperature change causing a sensor report.", + "unit": "°", "valueSize": 1, "minValue": 0, "maxValue": 70, @@ -134,7 +141,8 @@ { "#": "8", "label": "Auto Report Humidity", - "description": "Sets the humidity change causing a sensor report.", + "description": "Sets the humidity change causing a sensor report. 5%..70%, or 0 to disable.", + "unit": "%", "valueSize": 1, "minValue": 0, "maxValue": 70, From 2cdd52c12835000b2c350f389457f46419ca1c90 Mon Sep 17 00:00:00 2001 From: Gal Szkolnik Date: Fri, 8 Dec 2023 11:48:29 -0500 Subject: [PATCH 2/3] fix eslint:consistent-device-config-property-order --- packages/config/config/devices/0x0060/st814.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/config/config/devices/0x0060/st814.json b/packages/config/config/devices/0x0060/st814.json index 4f141178d7ad..38185a58cf27 100644 --- a/packages/config/config/devices/0x0060/st814.json +++ b/packages/config/config/devices/0x0060/st814.json @@ -30,8 +30,8 @@ "#": "1", "label": "Dim Level Sent via Basic Set", "description": "The dim level sent to a lamp module upon activation: (0) Off; (1)-(99) Dim Level", - "unit": "Brightness Level", "valueSize": 1, + "unit": "Brightness Level", "minValue": 0, "maxValue": 99, "defaultValue": 99, @@ -46,8 +46,8 @@ "#": "2", "label": "Temperature Trigger ON Value", "description": "Temperature level when a ON command is sent out. -20°..50° or 99 to disable.", - "unit": "°", "valueSize": 1, + "unit": "°", "minValue": -20, "maxValue": 99, "defaultValue": 99, @@ -62,8 +62,8 @@ "#": "3", "label": "Temperature Trigger OFF Value", "description": "Temperature level when a OFF command is sent out. -20°..50° or 99 to disable.", - "unit": "°", "valueSize": 1, + "unit": "°", "minValue": -20, "maxValue": 99, "defaultValue": 99, @@ -78,8 +78,8 @@ "#": "4", "label": "Humidity Trigger ON Value", "description": "Humidity level when a ON command is sent out. 20%..90%, or 99 to disable.", - "unit": "%", "valueSize": 1, + "unit": "%", "minValue": 20, "maxValue": 99, "defaultValue": 99, @@ -94,8 +94,8 @@ "#": "5", "label": "Humidity Trigger OFF Value", "description": "Humidity level when a OFF command is sent out. 20%..90%, or 99 to disable.", - "unit": "%", "valueSize": 1, + "unit": "%", "minValue": 20, "maxValue": 99, "defaultValue": 99, @@ -110,8 +110,8 @@ "#": "6", "label": "Auto Report Time", "description": "Sets the time interval when a sensor report is sent", - "unit": "minutes", "valueSize": 2, + "unit": "minutes", "minValue": 0, "maxValue": 1439, "defaultValue": 0, @@ -126,8 +126,8 @@ "#": "7", "label": "Auto Report Temperature", "description": "Sets the temperature change causing a sensor report.", - "unit": "°", "valueSize": 1, + "unit": "°", "minValue": 0, "maxValue": 70, "defaultValue": 0, @@ -142,8 +142,8 @@ "#": "8", "label": "Auto Report Humidity", "description": "Sets the humidity change causing a sensor report. 5%..70%, or 0 to disable.", - "unit": "%", "valueSize": 1, + "unit": "%", "minValue": 0, "maxValue": 70, "defaultValue": 0, From 12449f0affa7b932608b5da202202edcaf68625b Mon Sep 17 00:00:00 2001 From: Dominic Griesel Date: Tue, 2 Apr 2024 13:12:17 +0200 Subject: [PATCH 3/3] fix: consistency --- .../config/config/devices/0x0060/st814.json | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/packages/config/config/devices/0x0060/st814.json b/packages/config/config/devices/0x0060/st814.json index 38185a58cf27..3b3fc89930cc 100644 --- a/packages/config/config/devices/0x0060/st814.json +++ b/packages/config/config/devices/0x0060/st814.json @@ -29,9 +29,7 @@ { "#": "1", "label": "Dim Level Sent via Basic Set", - "description": "The dim level sent to a lamp module upon activation: (0) Off; (1)-(99) Dim Level", "valueSize": 1, - "unit": "Brightness Level", "minValue": 0, "maxValue": 99, "defaultValue": 99, @@ -45,9 +43,9 @@ { "#": "2", "label": "Temperature Trigger ON Value", - "description": "Temperature level when a ON command is sent out. -20°..50° or 99 to disable.", + "description": "Temperature level when a ON command is sent out. Allowable range -20..50, 99.", "valueSize": 1, - "unit": "°", + "unit": "°C/F", "minValue": -20, "maxValue": 99, "defaultValue": 99, @@ -61,9 +59,9 @@ { "#": "3", "label": "Temperature Trigger OFF Value", - "description": "Temperature level when a OFF command is sent out. -20°..50° or 99 to disable.", + "description": "Temperature level when a OFF command is sent out. Allowable range -20..50, 99.", "valueSize": 1, - "unit": "°", + "unit": "°C/F", "minValue": -20, "maxValue": 99, "defaultValue": 99, @@ -77,9 +75,9 @@ { "#": "4", "label": "Humidity Trigger ON Value", - "description": "Humidity level when a ON command is sent out. 20%..90%, or 99 to disable.", + "description": "Humidity level when a ON command is sent out. Allowable range 20..90, 99.", "valueSize": 1, - "unit": "%", + "unit": "%rH", "minValue": 20, "maxValue": 99, "defaultValue": 99, @@ -93,9 +91,9 @@ { "#": "5", "label": "Humidity Trigger OFF Value", - "description": "Humidity level when a OFF command is sent out. 20%..90%, or 99 to disable.", + "description": "Humidity level when a OFF command is sent out. Allowable range 20..90, 99.", "valueSize": 1, - "unit": "%", + "unit": "%rH", "minValue": 20, "maxValue": 99, "defaultValue": 99, @@ -127,7 +125,7 @@ "label": "Auto Report Temperature", "description": "Sets the temperature change causing a sensor report.", "valueSize": 1, - "unit": "°", + "unit": "°C/F", "minValue": 0, "maxValue": 70, "defaultValue": 0, @@ -141,9 +139,9 @@ { "#": "8", "label": "Auto Report Humidity", - "description": "Sets the humidity change causing a sensor report. 5%..70%, or 0 to disable.", + "description": "Sets the humidity change causing a sensor report. Allowable range: 0, 5..70.", "valueSize": 1, - "unit": "%", + "unit": "%rH", "minValue": 0, "maxValue": 70, "defaultValue": 0,