ZWLR Multicast Command Affects More Nodes Than Targeted

[AlCalzone]

Discussed in #7033

^{Originally posted by @alexschneider July 20, 2024}

Checklist

• I have read and followed the above instructions

• I have checked the troubleshooting section and my problem is not described there.

• I have read the changelog and my problem was not mentioned there or the fix did not work.

Describe the issue

What is happening?
When sending a multicast command, all nodes on the network that match the command class appear to be effected, even though only a subset were targeted.

What did you expect to happen instead?
Only the targeted nodes effected.

Steps to reproduce the behavior:
Send multicast command to a portion of nodes on the network.

Anything else we should know?

Software versions

zwave-js-ui: 9.16.1
zwave-js: 13.0.1
home id: 3806735750
home hex: 0xe2e62d86

Device information

Manufacturer: ZVIDAR
Model name: Z-CM-V01
Node ID: 256-265

(Most recent attempt to do multicast were nodes 263-265 but there are other attempts too)

Checklist

• I made sure to provide a driver log on level debug.

• The log includes a re-interview of the problematic device (if applicable).

• The log includes the problematic interaction with the device (if applicable).

• I provided the node ID of the problematic device (if applicable).

Upload Logfile

zwavejs_current.log

[AlCalzone]

After short investigation:

node-zwave-js/packages/core/src/security/Manager2.ts

Lines 158 to 159 in 38785b5

	const newHash = encodeNodeBitMask(nodeIDs).toString("hex");
	if (this.multicastGroupLookup.has(newHash)) {

does not consider node IDs above 232 when determining the "hash" that identifies a Multicast group