Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new DoubleConstant or LongConstant to the constants pool doesn't make them take up 2 slots #52

Open
zsr2531 opened this issue Apr 16, 2021 · 1 comment
Open

Adding a new DoubleConstant or LongConstant to the constants pool doesn't make them take up 2 slots #52

zsr2531 opened this issue Apr 16, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
v0.1.0

Comments

@zsr2531
Copy link
Owner

zsr2531 commented Apr 16, 2021

The current Add and Insert methods don't add the same constant twice if needed like this.

This will result in constant indices being misaligned.
@zsr2531 zsr2531 added the bug Something isn't working label Apr 16, 2021
@zsr2531 zsr2531 added this to the v0.1.0 milestone Apr 16, 2021
@zsr2531
Copy link
Owner Author

zsr2531 commented Apr 16, 2021

The same is true for Remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@zsr2531