Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow logger to be disabled at the class-constructor level #316

Closed
zFernand0 opened this issue Jul 17, 2024 · 2 comments · Fixed by #323
Closed

feat: Allow logger to be disabled at the class-constructor level #316

zFernand0 opened this issue Jul 17, 2024 · 2 comments · Fixed by #323
Assignees
Labels
enhancement New feature or request priority-medium
Milestone

Comments

@zFernand0
Copy link
Member

zFernand0 commented Jul 17, 2024

Is your feature or enhancement request related to a problem or limitation? Please describe

  • After Turning logger off #310 was implemented...
  • It would be great if we allowed the logger to be disabled as part of the class constructor

Describe your enhancement idea

As an example, someone could do Datasets(profile, log=False)

Describe alternatives you've considered

profile = ProfileManager().load(profile_type="zosmf", validate_schema=False)
ds = Datasets(profile)
Log.close_all()
console = Console(profile)
jobs = Jobs(profile)

The above will run off the logger for Datasets abut keep it open for the other classes since they are initialized after the Log.close_all() call

Provide any additional context

@zFernand0 zFernand0 added the enhancement New feature or request label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Jul 17, 2024
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@zFernand0 zFernand0 added this to the Post V1 LTS milestone Jul 17, 2024
@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe CLI Squad Jul 17, 2024
@aadityasinha-dotcom
Copy link
Contributor

Would like to work on this issue ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants