Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color themes to reader settings popup #1068

Closed
dstillman opened this issue Feb 13, 2025 · 2 comments · Fixed by #1070
Closed

Add color themes to reader settings popup #1068

dstillman opened this issue Feb 13, 2025 · 2 comments · Fixed by #1070

Comments

@dstillman
Copy link
Member

As on desktop, to allow switching between light mode and dark mode regardless of system setting

We should also add support for Sepia, which exists in PDF Viewer and is now supported in the EPUB reader. (We may have to leave out "Snow", since — assuming they don't allow custom color schemes — there's no equivalent in the PDF reader.)

@michalrentka
Copy link
Contributor

As on desktop, to allow switching between light mode and dark mode regardless of system setting

We allow that on iOS too

We should also add support for Sepia, which exists in PDF Viewer and is now supported in the EPUB reader. (We may have to leave out "Snow", since — assuming they don't allow custom color schemes — there's no equivalent in the PDF reader.)

Added sepia in #1070, custom schemes or backgrounds are not supported. I could contact their support and see their reaction.

@dstillman
Copy link
Member Author

We allow that on iOS too

Oh, whoops, I totally missed that last option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants