Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zope.interface 7 causing breakage #312

Closed
dataflake opened this issue Aug 6, 2024 · 1 comment · Fixed by #313
Closed

zope.interface 7 causing breakage #312

dataflake opened this issue Aug 6, 2024 · 1 comment · Fixed by #313
Assignees
Labels

Comments

@dataflake
Copy link
Member

In an unrelated project I am seeing the traceback shown below during GHA test runs using tox and zope.testrunner. The mentioned _zope_interface_coptimizations.ObjectSpecificationDescriptor is an addition in zope.interface version 7. I had to pin zope.interface to the previous release to make it go away.

py311-gha: commands[1]> coverage run /home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/bin/test
Traceback (most recent call last):
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/bin/test", line 41, in <module>
    sys.exit(zope.testrunner.run((['-cv']) + [
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/testrunner/__init__.py", line 31, in run
    failed = run_internal(defaults, args, script_parts=script_parts, cwd=cwd,
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/testrunner/__init__.py", line 52, in run_internal
    from zope.testrunner.runner import Runner
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/testrunner/runner.py", line 48, in <module>
    import zope.testrunner.tb_format
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/testrunner/tb_format.py", line 20, in <module>
    import zope.exceptions.exceptionformatter
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/exceptions/__init__.py", line 37, in <module>
    import zope.security  # noqa: suppress unused import warning from flake8
    ^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/security/__init__.py", line 20, in <module>
    import zope.security.decorator
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/security/decorator.py", line 22, in <module>
    from zope.proxy.decorator import SpecificationDecoratorBase
  File "/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/zope/proxy/decorator.py", line 30, in <module>
    class DecoratorSpecificationDescriptor(ObjectSpecificationDescriptor):
TypeError: type '_zope_interface_coptimizations.ObjectSpecificationDescriptor' is not an acceptable base type
/home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/lib/python3.11/site-packages/coverage/control.py:894: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
py311-gha: exit 1 (0.56 seconds) /home/runner/work/mw.importlib/mw.importlib> coverage run /home/runner/work/mw.importlib/mw.importlib/.tox/py311-gha/bin/test pid=3627
  py311-gha: FAIL code 1 (103.80=setup[36.75]+cmd[66.49,0.56] seconds)
  evaluation failed :( (104.00 seconds)
@tseaver
Copy link
Member

tseaver commented Aug 6, 2024

The fix is trivial -- we should push a 7.0.1 release (or 7.0post0?) as soon as the PR is merged.

@tseaver tseaver closed this as completed in 58a5a1b Aug 6, 2024
github-merge-queue bot referenced this issue in chezmoi-sh/atlas Aug 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | OpenSSF |
|---|---|---|---|
| [zope.interface](https://togithub.com/zopefoundation/zope.interface) |
major | `==6.4.post2` -> `==7.0.1` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/zopefoundation/zope.interface/badge)](https://securityscorecards.dev/viewer/?uri=github.com/zopefoundation/zope.interface)
|

---

### Release Notes

<details>
<summary>zopefoundation/zope.interface (zope.interface)</summary>

###
[`v7.0.1`](https://togithub.com/zopefoundation/zope.interface/blob/HEAD/CHANGES.rst#701-2024-08-06)

[Compare
Source](https://togithub.com/zopefoundation/zope.interface/compare/7.0...7.0.1)

\==================

- Fix subclassability of `ObjectSpecificationDescriptor` (broken in
7.0).
(`#&#8203;312
<https://github.com/zopefoundation/zope.interface/issues/312>`\_)

###
[`v7.0`](https://togithub.com/zopefoundation/zope.interface/blob/HEAD/CHANGES.rst#702-unreleased)

[Compare
Source](https://togithub.com/zopefoundation/zope.interface/compare/6.4.post2...7.0)

\==================

-   TBD

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/chezmoi-sh/atlas).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants