Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnIndex applies its _convert method on searching but not on indexing #69

Closed
andbag opened this issue Apr 12, 2019 · 1 comment · Fixed by #70
Closed

UnIndex applies its _convert method on searching but not on indexing #69

andbag opened this issue Apr 12, 2019 · 1 comment · Fixed by #70

Comments

@andbag
Copy link
Member

andbag commented Apr 12, 2019

There is another suboptimal thing with UnIndex:
it applies its _convert method on searching but not on indexing.

In general, it is adviceable to process the values for indexing
in the same way as those for searching - otherwise, there is
a risk that searches give surprising results.

The _convert of UnIndex is the identity. Thus, we do not see
a true error. However, if UnIndex would employ _convert homogenously
(both during indexing as well as during searching), then (e.g.)
DateIndex could define its own _convert
and use everything else from UnIndex/FieldIndex.

Originally posted by @d-maurer in #64 (comment)

andbag added a commit that referenced this issue Apr 12, 2019
@andbag
Copy link
Member Author

andbag commented Apr 12, 2019

PR #70 should solve the issue.

andbag added a commit that referenced this issue Apr 12, 2019
andbag added a commit that referenced this issue Apr 16, 2019
* Consolidate code for consistent use of `_convert` method
* Add more information to the log entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant