Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ doc for webhook cert related issue #132

Closed
haorenfsa opened this issue Jun 13, 2024 · 5 comments · Fixed by #210
Closed

FAQ doc for webhook cert related issue #132

haorenfsa opened this issue Jun 13, 2024 · 5 comments · Fixed by #210
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@haorenfsa
Copy link
Collaborator

solution in milvus-io/milvus#21961

related issue:
#108
milvus-io/milvus#33827

@haorenfsa haorenfsa added the documentation Improvements or additions to documentation label Jun 13, 2024
@haorenfsa haorenfsa self-assigned this Jun 13, 2024
@nustiueudinastea
Copy link
Contributor

@haorenfsa any idea why the cert.yaml is not part of the operator chart?

When looking at the operator instructions on this page: https://milvus.io/docs/install_cluster-milvusoperator.md, you can see in the example that the issuer and certificate resources are installed. But actually, the issuer and certificate resources are neither part of the chart, nor the standalone deployment.yaml. So probably the instructions doc was created with a different set of files.

Screenshot 2024-10-23 at 16 53 39

@nustiueudinastea
Copy link
Contributor

@haorenfsa I left a comment here going into more details regarding this issue: #108 (comment)

@haorenfsa
Copy link
Collaborator Author

haorenfsa commented Oct 25, 2024

Hi @nustiueudinastea

any idea why the cert.yaml is not part of the operator chart?

it's because the cert is dependent on cert-manager. Maybe we should make cert-manager's chart a dependency of milvus-operator directly.

There's now a walkaround to use a deployment without webhook: deployment-no-webhook.yaml

@nustiueudinastea
Copy link
Contributor

I don't think the chart should have a direct dependency on cert-manager, because most people already have that on their clusters. To me it makes more sense to create the certificate and issuer in the milvus-operator chart, but make it optional, with the ability to enable or disable it via a values.yaml flag, for people that might need to manage that in a different way.

@haorenfsa
Copy link
Collaborator Author

@nustiueudinastea Yeah, I agreee. let's do this in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants