-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ doc for webhook cert related issue #132
Comments
@haorenfsa any idea why the cert.yaml is not part of the operator chart? When looking at the operator instructions on this page: https://milvus.io/docs/install_cluster-milvusoperator.md, you can see in the example that the issuer and certificate resources are installed. But actually, the issuer and certificate resources are neither part of the chart, nor the standalone deployment.yaml. So probably the instructions doc was created with a different set of files. ![]() |
@haorenfsa I left a comment here going into more details regarding this issue: #108 (comment) |
it's because the cert is dependent on cert-manager. Maybe we should make cert-manager's chart a dependency of milvus-operator directly. There's now a walkaround to use a deployment without webhook: deployment-no-webhook.yaml |
I don't think the chart should have a direct dependency on cert-manager, because most people already have that on their clusters. To me it makes more sense to create the certificate and issuer in the milvus-operator chart, but make it optional, with the ability to enable or disable it via a values.yaml flag, for people that might need to manage that in a different way. |
@nustiueudinastea Yeah, I agreee. let's do this in next release. |
solution in milvus-io/milvus#21961
related issue:
#108
milvus-io/milvus#33827
The text was updated successfully, but these errors were encountered: