From 8e41f2a2a439c214e1da536cfb0cdfb380c1562f Mon Sep 17 00:00:00 2001
From: Rachit Chaudhary - r0c0axe <Rachit.Chaudhary@walmart.com>
Date: Tue, 27 Feb 2024 15:01:14 +0530
Subject: [PATCH] Bump milvus version to v4.1.22

Signed-off-by: Rachit Chaudhary - r0c0axe <Rachit.Chaudhary@walmart.com>
---
 charts/milvus/Chart.yaml                           | 2 +-
 charts/milvus/templates/datacoord-deployment.yaml  | 7 ++++++-
 charts/milvus/templates/indexcoord-deployment.yaml | 7 ++++++-
 charts/milvus/templates/querycoord-deployment.yaml | 7 ++++++-
 charts/milvus/templates/rootcoord-deployment.yaml  | 7 ++++++-
 charts/milvus/values.yaml                          | 6 ++++++
 6 files changed, 31 insertions(+), 5 deletions(-)

diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
index 9b1ff0e..80ff4b7 100644
--- a/charts/milvus/Chart.yaml
+++ b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.3.10"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 4.1.21
+version: 4.1.22
 keywords:
   - milvus
   - elastic
diff --git a/charts/milvus/templates/datacoord-deployment.yaml b/charts/milvus/templates/datacoord-deployment.yaml
index 2e0421c..22757ff 100644
--- a/charts/milvus/templates/datacoord-deployment.yaml
+++ b/charts/milvus/templates/datacoord-deployment.yaml
@@ -13,7 +13,12 @@ metadata:
 spec:
   replicas: {{ .Values.dataCoordinator.replicas }}
   strategy:
-    type: Recreate
+    type: {{ .Values.DeploymentUpdate.type }}
+    {{- if eq .Values.DeploymentUpdate.type "RollingUpdate" }}
+    rollingUpdate:
+      maxSurge: {{ .Values.DeploymentUpdate.maxSurge }}
+      maxUnavailable: {{ .Values.DeploymentUpdate.maxUnavailable }}
+    {{- end }}
   selector:
     matchLabels:
 {{ include "milvus.matchLabels" . | indent 6 }}
diff --git a/charts/milvus/templates/indexcoord-deployment.yaml b/charts/milvus/templates/indexcoord-deployment.yaml
index c6fa1ec..8b71dd4 100644
--- a/charts/milvus/templates/indexcoord-deployment.yaml
+++ b/charts/milvus/templates/indexcoord-deployment.yaml
@@ -13,7 +13,12 @@ metadata:
 spec:
   replicas: {{ .Values.indexCoordinator.replicas }}
   strategy:
-    type: Recreate
+    type: {{ .Values.DeploymentUpdate.type }}
+    {{- if eq .Values.DeploymentUpdate.type "RollingUpdate" }}
+    rollingUpdate:
+      maxSurge: {{ .Values.DeploymentUpdate.maxSurge }}
+      maxUnavailable: {{ .Values.DeploymentUpdate.maxUnavailable }}
+    {{- end }}
   selector:
     matchLabels:
 {{ include "milvus.matchLabels" . | indent 6 }}
diff --git a/charts/milvus/templates/querycoord-deployment.yaml b/charts/milvus/templates/querycoord-deployment.yaml
index 59d407f..e7df730 100644
--- a/charts/milvus/templates/querycoord-deployment.yaml
+++ b/charts/milvus/templates/querycoord-deployment.yaml
@@ -13,7 +13,12 @@ metadata:
 spec:
   replicas: {{ .Values.queryCoordinator.replicas }}
   strategy:
-    type: Recreate
+    type: {{ .Values.DeploymentUpdate.type }}
+    {{- if eq .Values.DeploymentUpdate.type "RollingUpdate" }}
+    rollingUpdate:
+      maxSurge: {{ .Values.DeploymentUpdate.maxSurge }}
+      maxUnavailable: {{ .Values.DeploymentUpdate.maxUnavailable }}
+    {{- end }}
   selector:
     matchLabels:
 {{ include "milvus.matchLabels" . | indent 6 }}
diff --git a/charts/milvus/templates/rootcoord-deployment.yaml b/charts/milvus/templates/rootcoord-deployment.yaml
index c8c3cd3..082fd83 100644
--- a/charts/milvus/templates/rootcoord-deployment.yaml
+++ b/charts/milvus/templates/rootcoord-deployment.yaml
@@ -13,7 +13,12 @@ metadata:
 spec:
   replicas: {{ .Values.rootCoordinator.replicas }}
   strategy:
-    type: Recreate
+    type: {{ .Values.DeploymentUpdate.type }}
+    {{- if eq .Values.DeploymentUpdate.type "RollingUpdate" }}
+    rollingUpdate:
+      maxSurge: {{ .Values.DeploymentUpdate.maxSurge }}
+      maxUnavailable: {{ .Values.DeploymentUpdate.maxUnavailable }}
+    {{- end }}
   selector:
     matchLabels:
 {{ include "milvus.matchLabels" . | indent 6 }}
diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
index 9f3be0b..8607fef 100644
--- a/charts/milvus/values.yaml
+++ b/charts/milvus/values.yaml
@@ -923,3 +923,9 @@ externalKafka:
     mechanisms: PLAIN
     username: ""
     password: ""
+
+## Update strategy for Deployments
+DeploymentUpdate:
+  type: RollingUpdate
+  maxUnavailable: 25%
+  maxSurge: 25%