Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI help doesn't work in 0.0.20 release #444

Open
Luka958Pixion opened this issue Jan 9, 2025 · 1 comment
Open

CLI help doesn't work in 0.0.20 release #444

Luka958Pixion opened this issue Jan 9, 2025 · 1 comment
Assignees

Comments

@Luka958Pixion
Copy link
Contributor

Luka958Pixion commented Jan 9, 2025

  • MemoryDBHNSWTypedDict raises exception

vectordbbench --help

Traceback (most recent call last):
  File "/home/my_username/VectorDBBench/venv/bin/vectordbbench", line 5, in <module>
    from vectordb_bench.cli.vectordbbench import cli
  File "/home/my_username/VectorDBBench/vectordb_bench/cli/vectordbbench.py", line 3, in <module>
    from ..backend.clients.memorydb.cli import MemoryDB
  File "/home/my_username/VectorDBBench/vectordb_bench/backend/clients/memorydb/cli.py", line 66, in <module>
    @click_parameter_decorators_from_typed_dict(MemoryDBHNSWTypedDict)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/my_username/VectorDBBench/vectordb_bench/cli/cli.py", line 103, in deco
    f = dec(f)
        ^^^^^^
  File "/home/my_username/VectorDBBench/venv/lib/python3.12/site-packages/click/decorators.py", line 365, in decorator
    _param_memo(f, cls(param_decls, **attrs))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/my_username/VectorDBBench/venv/lib/python3.12/site-packages/click/core.py", line 2536, in __init__
    help = inspect.cleandoc(help)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/inspect.py", line 888, in cleandoc
    lines = doc.expandtabs().split('\n')
            ^^^^^^^^^^^^^^
AttributeError: 'tuple' object has no attribute 'expandtabs'
@XuanYang-cn XuanYang-cn self-assigned this Jan 9, 2025
@XuanYang-cn
Copy link
Collaborator

working on fixing this

XuanYang-cn added a commit to XuanYang-cn/VectorDBBench that referenced this issue Jan 10, 2025
fix: remove comma of logging str
fix cli unable to run zilliztech#444

Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/VectorDBBench that referenced this issue Jan 10, 2025
fix: remove comma of logging str
fix cli unable to run zilliztech#444

Signed-off-by: yangxuan <[email protected]>
alwayslove2013 pushed a commit that referenced this issue Jan 13, 2025
fix: remove comma of logging str
fix cli unable to run #444

Signed-off-by: yangxuan <[email protected]>
shaharuk-yb added a commit to yugabyte/VectorDBBench that referenced this issue Jan 16, 2025
* fix: Unable to run vebbench and cli

fix: remove comma of logging str
fix cli unable to run zilliztech#444

Signed-off-by: yangxuan <[email protected]>

* enhance: Unify optimize and remove ready_to_load

PyMilvus used to be the only client that uses ready_to_load.
Not it'll load the collection when creating it, so
this PR removes `ready_to_load` from the client.API

Also this PR enhance optimize and remove the optimize_with_size

Signed-off-by: yangxuan <[email protected]>

* add mongodb client

Signed-off-by: zhuwenxing <[email protected]>

* add mongodb client in readme

Signed-off-by: zhuwenxing <[email protected]>

---------

Signed-off-by: yangxuan <[email protected]>
Signed-off-by: zhuwenxing <[email protected]>
Co-authored-by: yangxuan <[email protected]>
Co-authored-by: zhuwenxing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants