Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RemoveInboundTracker #1345

Open
lumtis opened this issue Oct 25, 2023 · 5 comments · May be fixed by #3469
Open

Implement RemoveInboundTracker #1345

lumtis opened this issue Oct 25, 2023 · 5 comments · May be fixed by #3469
Assignees

Comments

@lumtis
Copy link
Member

lumtis commented Oct 25, 2023

We currently have the message RemoveFromOutTxTracker that allows to manually remove a out tx tracker by an admin group 1.

func (k msgServer) RemoveFromOutTxTracker(goCtx context.Context, msg *types.MsgRemoveFromOutTxTracker) (*types.MsgRemoveFromOutTxTrackerResponse, error) {

Would it make sense to have a similar mechanism for InTx tracker ?

cc @kingpinXD

@kingpinXD
Copy link
Contributor

It would be good, but I feel it might be lower on our priority list .
As opposed to outtxtrackers created for every outbound, the inTx trackers would be created manually or by a separate process that scans external chains looking for missed trackers.
something like this : https://github.com/zeta-chain/node/blob/add-xcheck-cmd/cmd/xcheck/main.go

We could add more stringent checks before creating the tracker first. What do you think?

@lumtis
Copy link
Member Author

lumtis commented Oct 25, 2023

Ok, thanks for the context, it sounds good to let this issue aside for the time being.

@brewmaster012
Copy link
Collaborator

I was thinking about the other direction;
since adding trackers is relatively easy, we can set expiration of the intx tracker (or periodically purge them).
This also is needed for better spam (is the checking enough to ward off all spams?) control, via requiring intx tracker submitter to post some ZETA as bond.

@lumtis lumtis closed this as completed Aug 20, 2024
@lumtis lumtis reopened this Nov 14, 2024
@lumtis lumtis added this to the Future milestone Nov 14, 2024
@kingpinXD kingpinXD self-assigned this Nov 14, 2024
@lumtis lumtis changed the title Implement RemoveFromInTxTracker Implement RemoveInboundTracker Nov 24, 2024
@kingpinXD
Copy link
Contributor

Trackers with expiry would mean

  1. We only query non-expired trackers
  2. We still need a mechanism to clean up expired trackers to prevent these trackers from increasing the size of the state .
    This cleanup can be
  • BeginBlock logic.
  • A trasnaction.

I dont think adding more logic in the begin block is preferable , as it is harder to test and not under active control.

If we decide to go with the tx route I guess , implementing the original msg to delete the tracker is much simpler than having an expiry mechanism and deleting expired tracker

@kingpinXD kingpinXD linked a pull request Feb 5, 2025 that will close this issue
5 tasks
@kingpinXD
Copy link
Contributor

Confirminf as this issue is quite onl
RemoveFromOutTxTracker has been removed and replaced by MsgAddOutboundTracker
"/zetachain.zetacore.crosschain.MsgAddOutboundTracker",
"/zetachain.zetacore.crosschain.MsgRemoveOutboundTracker",

All the admin messages related to trackers are under Emergency group now, I think we should add the new MsgRemoveInboundTracker under the same group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants