-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please include async-channel in benchmarks #58
Comments
Currently, there are no benchmarks which are asynchronous, as we're not really sure how async benches should be measured. Do you have any suggestions to do so? The other option would be to wrap each call to async-channel in |
@Restioson I'd suggest two benchmarks: Thread-per-CPU and Single-threaded. (There are other possible configurations, but those will be the most common.) The actual benchmarks should be all the same things you currently benchmark, with the producers and consumers sitting in separate tasks, and the only question is whether those tasks run concurrently or not. You already have flume synchronous benchmarks; you could add "flume async thread-per-CPU", "flume async single-threaded", "async-channel thread-per-CPU", and "async-channel single-threaded". (That'll also allow comparing flume sync and async performance.) |
How should the performance of the tasks be measured? We could |
You could call For thread-per-CPU, something like |
Please consider adding the async-channel crate to the benchmarks. It's part of the async-std and smol stacks, and I would like to see how it compares.
The text was updated successfully, but these errors were encountered: