Reject redefinition of Object operations #3329
Merged
+105
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsertCreativityHere
approved these changes
Jan 9, 2025
| @@ -723,6 +723,9 @@ namespace Slice | |||
| private: | |||
| friend class Container; | |||
|
|
|||
| // Returns true if name does not collide with any base name; otherwise, false. | |||
| bool checkBaseOperationNames(const std::string& name, const std::vector<std::string>& baseNames); | |||
There was a problem hiding this comment.
I know that we're using this to check for collisions with base names, but the implementation itself isn't specific to base names.
I think a name like checkForNameCollision would be more apt for this function.
Along with changing baseNames to otherNames or something.
There was a problem hiding this comment.
The implementation is specific to base operation names: please read the error messages.
There was a problem hiding this comment.
Yes, you're right. It should be left as-is.
externl
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3318.