Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused connect callbacks #23

Open
pepone opened this issue Oct 8, 2024 · 0 comments
Open

Unused connect callbacks #23

pepone opened this issue Oct 8, 2024 · 0 comments
Labels

Comments

@pepone
Copy link
Member

pepone commented Oct 8, 2024

std::vector<std::function<void(std::shared_ptr<DataStormContract::SessionPrx>)>> _connectedCallbacks;

The SessionI object has a collection of connect callbacks, but seems it is always empty:

jose@mac datastorm % rg _connectedCallbacks    
cpp/src/DataStorm/SessionI.cpp
512:        assert(_connectedCallbacks.empty());
565:    for(auto c : _connectedCallbacks)
569:    _connectedCallbacks.clear();
771:    for(auto c : _connectedCallbacks)
775:    _connectedCallbacks.clear();

cpp/src/DataStorm/SessionI.h
365:    std::vector<std::function<void(std::shared_ptr<DataStormContract::SessionPrx>)>> _connectedCallbacks;
@pepone pepone added the bug label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant