Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runtime.SetFinalizer for C-backed objects #2

Open
davidben opened this issue Nov 8, 2016 · 1 comment
Open

Use runtime.SetFinalizer for C-backed objects #2

davidben opened this issue Nov 8, 2016 · 1 comment

Comments

@davidben
Copy link
Contributor

davidben commented Nov 8, 2016

krb5-go tries to avoid making too many objects backed by C, but a handful are (Context and CCache). Those should use runtime.SetFinalizer to clean themselves up and runtime.SetFinalizer(blah, nil) if closed explicitly. (This appears to be what the standard library os.File does internally.)
@davidben
Copy link
Contributor Author

davidben commented Nov 8, 2016

Although that finalizers are run on another goroutine probably means some additional care or locking is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidben