Rust auto-import selecting the incorrect entry

[road2react]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

When there are multiple similar items, it always imports the first one, even if the other ones are selected.

Example:

fn main() {
    let x = Weak
}

When auto-importing Weak, selecting std::sync::Weak imports std::rc::Weak instead.

Environment

Zed: v0.159.5 (Zed)
OS: Linux Wayland arch unknown
Memory: 93.5 GiB
Architecture: x86_64
GPU: AMD Radeon 680M (RADV REMBRANDT) || radv || Mesa 24.2.6-arch1.1

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

[osiewicz]

I cannot reproduce this on latest nightly.

[dovakin0007]

I cannot reproduce this on latest nightly.

then it's fixed?

[Sliman4]

Haven't tried on nightly, but 0.159.9 doesn't import the first one (even though I want the first one)
Screencast_20241105_191957.webm

[aalhitennf]

Having same problem with zed 0.160.7.

Description on right is showing documentation for env_logger::fmt::style::Style, which it also imports if selected.

[SomeoneToIgnore]

This will be fixed

• either in Use completion item indices instead of property matching when searching for the completion item to resolve rust-lang/rust-analyzer#18503
• or by other, more clever approach
• or, worst case, by the revert PR: Revert "Resolve completion items" rust-lang/rust-analyzer#18501

[SomeoneToIgnore]

rust-lang/rust-analyzer#18503 should have been released today with rust-analyzer, so closing this.

Please comment here if things are not working still and you're sure you're using the rust-analyzer-2024-11-18 or later.