Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review ports sharing arch #314

Open
vdelendik opened this issue Apr 24, 2024 · 1 comment
Open

review ports sharing arch #314

vdelendik opened this issue Apr 24, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@vdelendik
Copy link
Contributor

let's inspect ports sharing we have to do to organize adb and potentially usbmuxd remote connection.
goal to hide as much as possible and do not expose extra ports.

For example if we deploy stf-agent-proxy near the devices we can organize routing for screen port using
nginx <-> agent-nginx <-> device container

wss://demo.zebrunner.farm/d/demo.zebrunner.farm/<udid>/7544/
->
wss://demo.zebrunner.farm/d/demo.zebrunner.farm/<device-container>/7544/

global nginx then should redirect to agent nginx:

    # Handle stf-providers
    location ~ "^/d/(?<stfprovider>([^/]+))/(?<udid>([^/]+))/(?<port>[0-9]+)/$" {
      proxy_pass http://$stfprovider:$STF-AGENT-PROXY-PORT/;
      proxy_http_version 1.1;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection upgrade;
      proxy_set_header X-Forwarded-For $remote_addr;
      proxy_set_header X-Real-IP $remote_addr;
    }

And agent nginx using device container routing goto screen port etc

@vdelendik vdelendik added the enhancement New feature or request label Apr 24, 2024
@vdelendik vdelendik added this to the 2.7 milestone Apr 24, 2024
@vdelendik vdelendik modified the milestones: 2.7, 3.0 May 17, 2024
@vdelendik
Copy link
Contributor Author

still TBD if really need this complication. To identify it we have to double check functionality in 2.7 release. As I remember we removed mjpeg screen port sharing outside at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant